Remove unused state_id foreign key #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
reviewed
Aug 11, 2020
services/postgres/alembic/versions/2020-08-08T205817_remove_state_id_foreign_keys.py
Show resolved
Hide resolved
services/postgres/alembic/versions/2020-08-08T205817_remove_state_id_foreign_keys.py
Show resolved
Hide resolved
cicdw
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect Server!
Please describe your work and make sure your PR:
changes/directory (if appropriate)Note that your PR will not be reviewed unless these two boxes are checked.
What does this PR change?
This PR removes a foreign key on
task_run.state_idandflow_run.state_idthat once pointed to the current state; it is unused and creates performance issues.Why is this PR important?