-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiet loop logs; improve loop intervals #43
Conversation
@cicdw made the following changes:
|
Closing this as we've made (most of) these adjustments elsewhere. |
Reopening following offline conversation that the remaining enhancements in this PR may be desirable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request to reuse an existing attribute, otherwise this LGTM
@@ -40,21 +44,19 @@ def __init__(self, loop_seconds: Union[float, int] = None): | |||
self.loop_seconds = float(loop_seconds) | |||
self.name = type(self).__name__ | |||
self.logger = utilities.logging.get_logger(self.name) | |||
self._stop_running = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have an _is_running
attribute that you should probably reuse instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this will be a nice QOL improvement
Thanks for contributing to Prefect Server!
Please describe your work and make sure your PR:
changes/
directory (if appropriate)Note that your PR will not be reviewed unless these two boxes are checked.
What does this PR change?
This PR: