Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding error checking for missing aws folder and files #23

Merged
merged 2 commits into from
May 16, 2019
Merged

adding error checking for missing aws folder and files #23

merged 2 commits into from
May 16, 2019

Conversation

thorix
Copy link
Collaborator

@thorix thorix commented May 3, 2019

Fix for #22

bartlettc22
bartlettc22 approved these changes May 16, 2019
View reviewed changes
pkg/aws/profiles.go Outdated

return credentialPath, nil
}

// Exists returns whether the given file or directory exists
func Exists(path string) (bool, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a more descriptive name and maybe move it to the utils pkg as I could see this needing to be reused.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

@thorix thorix merged commit 2f4251a into master May 16, 2019
@thorix thorix deleted the aws_profile_fix branch May 16, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettc22 bartlettc22 bartlettc22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorix @bartlettc22