RBAC, cert-manager, etc. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thorix
reviewed
May 16, 2019
| * Adding RBAC support | ||
| * Additional TCP option support for Vault | ||
| * Will now automatically roll deployments when Vault config changes | ||
|
|
There was a problem hiding this comment.
The CertManger will be nice. Still can use letsEncrypt, but will now have something updating the 90-day certs.
thorix
reviewed
May 16, 2019
| cp /vault/config-ro/config.json /vault/config/config.json | ||
| docker-entrypoint.sh server | ||
| args: | ||
| - "server" |
There was a problem hiding this comment.
This is an important change. This will enable dumb-init to be process one again. Currently, Hashicorp Consul's helm doesn't do this correctly!
thorix
reviewed
May 16, 2019
| @@ -73,6 +75,9 @@ Vault: | |||
| DisableConsulRegistration: "false" | |||
| DefaultLeaseTtl: "768h" | |||
| MaxLeaseTtl: "768h" | |||
| # config: | |||
| # tcpAdditionalOptions: | | |||
| # tls_disable_client_certs = "true" | |||
There was a problem hiding this comment.
Doesn't this seem like it should be a default for Vault from Hashicorp? Many people noticed a chrome pop-up when opening the Vault web interface asking for them to select a client cert to continue with...
|
Overall this PR looks good. This PR has been tested and everything seems to be in order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PodManagementPolicyoptional for statefulsets to allow upgrading of older clustersAddresses issue #47, #3