Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error screens on Storybook #1149

Closed
wants to merge 14 commits into from
Closed

Add error screens on Storybook #1149

wants to merge 14 commits into from

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jan 30, 2025 •
edited
Loading

Blocked by #1135

Questions Answers
Description? The error screens won't be easy t reproduce on production. Stories are added on Storybook to vizualise all of them. To make this possible, I added the JS project in Sotrybook.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Open Storybook. All the error implemented in #1135 should be accessible.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jan 30, 2025
@Quetzacoalt91 Quetzacoalt91 changed the title Add error screens on strorybook Add error screens on Storybook Jan 30, 2025
@Quetzacoalt91 Quetzacoalt91 force-pushed the add-error-screens-on-strorybook branch from 0dc2245 to e2a9fb0 Compare January 31, 2025 16:15
@Quetzacoalt91 Quetzacoalt91 added enhancement Type: Improvement Blocked Status: The issue is blocked by another task labels Feb 6, 2025
@Quetzacoalt91 Quetzacoalt91 force-pushed the add-error-screens-on-strorybook branch from e2a9fb0 to 7fe28ca Compare February 7, 2025 16:43
@Quetzacoalt91 Quetzacoalt91 force-pushed the add-error-screens-on-strorybook branch from 7fe28ca to 08f454d Compare February 7, 2025 17:11
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Quetzacoalt91
Copy link
Member Author

Commits have been integrated in #1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Quetzacoalt91 Quetzacoalt91

@tblivet tblivet

Labels
Blocked Status: The issue is blocked by another task enhancement Type: Improvement
Projects
PR Dashboard
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quetzacoalt91 @tblivet