Add new hooks in sql upgrade statement #1168
Conversation
tleon
commented
Feb 11, 2025
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Added the new hooks from 9.0.x to the sql upgrade statement |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #37163 |
| Sponsor company | PrestaShop SA |
| How to test? | CI green |
There was a problem hiding this comment.
@tleon I think you should update the part that @jolelievre added in his previous PR, because, for example, the part deleting the hooks is identical
tleon
force-pushed
the
add-new-hooks-in-sql-statement
branch
from
c700bd9 to
3a0027e
Compare
|
| (NULL, 'dashboardData', '', '', '1'), | ||
| (NULL, 'actionPasswordRenew', '', '', '1'), | ||
| (NULL, 'actionDownloadAttachment', '', '', '1'), | ||
| (NULL, 'fooHook', '', '', '1'), |
There was a problem hiding this comment.
Is there really a hook with this name in production?
There was a problem hiding this comment.
There was a problem hiding this comment.
yes, this is the same problem as with the generated docs, some of the hooks should be excluded, I added more comments on this PR
There was a problem hiding this comment.
In the end i don't know anymore if this command is a good idea i'm a but tired of all of this :/
There was a problem hiding this comment.
it is a good idea and it works great, the most important remaining thing is to have block-list of hooks available, so you don't generate them, hooks from tests directory, and hooks that are deprecated :)
There was a problem hiding this comment.
Instead of a s list of blocked hooks we could have instead a list of folders that the scanner shouldn't scan
|
How will users be able to use hooks without them having a description ? |
| @@ -323,3 +323,106 @@ ALTER TABLE `PREFIX_attachment_lang` MODIFY COLUMN `name` varchar(255) DEFAULT N | |||
| /* Fix category thumbnail images */ | |||
| /* https://github.com/PrestaShop/PrestaShop/pull/36877 */ | |||
| /* PHP:ps_900_migrate_category_images(); */; | |||
|
|
|||
| /* Auto generated hooks added for version 9.0.0 */ | |||
| INSERT INTO `PREFIX_hook` (`id_hook`, `name`, `title`, `description`, `position`) VALUES | |||
There was a problem hiding this comment.
Be careful the list of inserted hooks is already upper in this file The command is able to generate the SQL query but it cannot modify this file "in place", it only appends the content at the end So we need to manually keep the file consistent (either move this added code upper in the file or remove the upper part)
