-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates: double quotes => single quote (for Smarty strings) #601
Conversation
yannicka
commented
Feb 23, 2024
Questions | Answers |
---|---|
Description? | Chunk of #593. Strings in Smarty templates all (or almost all) use single quotes instead of double quotes. |
Type? | refactor |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | N/A |
Sponsor company | N/A |
How to test? | Install the theme and browse the website. |
@yannicka after the merge of one of your PRs there are some conflicts there :( probably it will be a bit of a pain since your previous PR changed spaces 😓 |
Should be good ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yannicka ,
I tested with develop branch of PS and PHP 8.1.
I have an internal server error when installing the hummingbird theme PR.
![Screenshot 2024-02-28 at 09 40 54](https://private-user-images.githubusercontent.com/16019289/308479836-762398b7-ca3e-46b4-8d47-fa99b0dc13a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTc0ODEsIm5iZiI6MTczOTAxNzE4MSwicGF0aCI6Ii8xNjAxOTI4OS8zMDg0Nzk4MzYtNzYyMzk4YjctY2EzZS00NmI0LThkNDctZmE5OWIwZGMxM2E1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyMTk0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5OTA0M2VlMWNhYjU1Njc4MDFjNWYwNWRkOTQ1OWM1MzExNmVlNWQ5ODZhYzRiYzkxYWZmY2EyNmJiNGMyMzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kAaW30l55m_zkx_HunVoe3klD3n6V-00DVyMIN0zzTE)
With classic theme, it works as expected.
Could you check ? :)
Thanks!
@florine2623, could you check what the logs say? because this is just a generic error message |
For my part, I can install the theme with this modification, and the theme works. If you activate debug mode, it will display more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yannicka ,
Retested the theme on develop
. I do not have any errors. Probably a problem with my server 😅
Tested :
- creation of a product in BO and checked product page in FO
- checked categories page
- log into customer page
- checked customer account pages
- processed to checkout
- checked content pages
LGTM ✅