Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defined() with quotes is not optional #15

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Use defined() with quotes is not optional #15

merged 1 commit into from
Jun 18, 2021

Conversation

lmeyer1
Copy link
Contributor

@lmeyer1 lmeyer1 commented Jun 17, 2021 •
edited by matthieu-rolland
Loading

Questions Answers
Description? Use defined() with quotes, they're not optional.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #25002
How to test? Look at the code is sufficient.
Possible impacts? None.

@lmeyer1 lmeyer1 mentioned this pull request Jun 17, 2021
Closed
@PierreRambaud PierreRambaud changed the base branch from master to dev June 17, 2021 14:18
@PierreRambaud PierreRambaud added this to the 2.0.1 milestone Jun 18, 2021
@PierreRambaud PierreRambaud merged commit 6500691 into PrestaShop:dev Jun 18, 2021
@PierreRambaud
Copy link
Contributor

Thank you @lmeyer1

@lmeyer1 lmeyer1 deleted the patch-1 branch June 18, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lmeyer1 @PierreRambaud @matthieu-rolland