Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linkedin #15

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Add linkedin #15

merged 1 commit into from
Jan 27, 2020

Conversation

davideapvd
Copy link
Contributor

@davideapvd davideapvd commented Jan 14, 2020 •
edited by sarahdib
Loading

#12

@PierreRambaud PierreRambaud changed the base branch from master to dev January 14, 2020 16:07
@PierreRambaud PierreRambaud changed the title add linkedin Add linkedin Jan 14, 2020
@PierreRambaud PierreRambaud added the waiting for QA Status: Waiting for QA feedback label Jan 14, 2020
@khouloudbelguith khouloudbelguith mentioned this pull request Jan 14, 2020
Open
@sarahdib
Copy link

Hello @davideapvd
Thank you for your pull request.

@TristanLDD I think we need a pictogram for linkedin link what do you think ?
Capture d’écran 2020-01-16 à 22 38 23

@sarahdib sarahdib added Waiting for UX and removed waiting for QA Status: Waiting for QA feedback labels Jan 16, 2020
@TristanLDD
Copy link

@sarahdib Yes, here is the Linkedin icon:

  • icons8-linkedin-2-96
    (it's white on white background)

@sarahdib
Copy link

@davideapvd could you integrate the icon @TristanLDD provide ?

Thank you

@davideapvd
Copy link
Contributor Author

@sarahdib I think the icons are handled by the base theme https://github.com/PrestaShop/PrestaShop/blob/develop/themes/classic/_dev/css/components/footer.scss#L65 and they all are in svg format (black/white) , am I correct?

@sarahdib
Copy link

@davideapvd Ok I will upgrade the issue and validate your PR.

@Progi1984 Progi1984 merged commit fba507a into PrestaShop:dev Jan 27, 2020
@Progi1984
Copy link
Member

Thanks @davideapvd

This was referenced Feb 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davideapvd @sarahdib @TristanLDD @Progi1984 @PierreRambaud