-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBO-94] Remove badges and Merchant expertise page #105
Merged
Progi1984
merged 6 commits into
PrestaShopCorp:3.x
from
sowbiba:feat/MBO-94/remove-badges-and-merchant-expertise-page
Sep 22, 2022
Merged
[MBO-94] Remove badges and Merchant expertise page #105
Progi1984
merged 6 commits into
PrestaShopCorp:3.x
from
sowbiba:feat/MBO-94/remove-badges-and-merchant-expertise-page
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sowbiba
commented
Sep 8, 2022
Questions | Answers |
---|---|
Description? | Remove badges and Merchant expertise page. This includes tables, controllers, tabs, deprecated config values ... |
Type? | new feature |
BC breaks? | yes |
Deprecations? | no |
Fixed ticket? | Fixes MBO-94 |
How to test? | See MBO-94 |
Pull Request Test Coverage Report for Build 3015240140
💛 - Coveralls |
@intraordinaire and @Progi1984 I really need your reviews to check if I forget some code to clean, If there are some features I should not remove ... |
Progi1984
requested changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need migration for removing table, tabs & configuration values
Progi1984
approved these changes
Sep 16, 2022
Progi1984
approved these changes
Sep 16, 2022
sowbiba
force-pushed
the
feat/MBO-94/remove-badges-and-merchant-expertise-page
branch
from
September 16, 2022 09:55
19bf2a7
to
f2754fb
Compare
Progi1984
approved these changes
Sep 16, 2022
sowbiba
force-pushed
the
feat/MBO-94/remove-badges-and-merchant-expertise-page
branch
2 times, most recently
from
September 22, 2022 09:06
d1a0949
to
5f8ce9f
Compare
sowbiba
force-pushed
the
feat/MBO-94/remove-badges-and-merchant-expertise-page
branch
from
September 22, 2022 09:56
e8cea7e
to
b4cbc38
Compare
QA approuved |
Thanks @sowbiba & @NicolasJOUGNEAU |
sowbiba
deleted the
feat/MBO-94/remove-badges-and-merchant-expertise-page
branch
September 22, 2022 10:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.