Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBO-94] Remove badges and Merchant expertise page #105

Conversation

sowbiba
Copy link
Contributor

@sowbiba sowbiba commented Sep 8, 2022

Questions Answers
Description? Remove badges and Merchant expertise page. This includes tables, controllers, tabs, deprecated config values ...
Type? new feature
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes MBO-94
How to test? See MBO-94

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3015240140

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.6%) to 6.863%

Changes Missing Coverage Covered Lines Changed/Added Lines %
classes/Condition.php 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
classes/Condition.php 2 0%
Totals Coverage Status
Change from base Build 2434124620: 2.6%
Covered Lines: 14
Relevant Lines: 204

💛 - Coveralls

@sowbiba
Copy link
Contributor Author

sowbiba commented Sep 8, 2022

@intraordinaire and @Progi1984

I really need your reviews to check if I forget some code to clean, If there are some features I should not remove ...

@sowbiba sowbiba changed the base branch from dev to 3.x September 8, 2022 13:04
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need migration for removing table, tabs & configuration values

@sowbiba sowbiba requested a review from Progi1984 September 15, 2022 15:59
@sowbiba sowbiba force-pushed the feat/MBO-94/remove-badges-and-merchant-expertise-page branch from 19bf2a7 to f2754fb Compare September 16, 2022 09:55
@sowbiba sowbiba force-pushed the feat/MBO-94/remove-badges-and-merchant-expertise-page branch 2 times, most recently from d1a0949 to 5f8ce9f Compare September 22, 2022 09:06
@sowbiba sowbiba force-pushed the feat/MBO-94/remove-badges-and-merchant-expertise-page branch from e8cea7e to b4cbc38 Compare September 22, 2022 09:56
@NicolasJOUGNEAU
Copy link

QA approuved

@Progi1984 Progi1984 merged commit 080c3e3 into PrestaShopCorp:3.x Sep 22, 2022
@Progi1984
Copy link
Contributor

Thanks @sowbiba & @NicolasJOUGNEAU

@sowbiba sowbiba deleted the feat/MBO-94/remove-badges-and-merchant-expertise-page branch September 22, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants