Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple station URLs on Register and more #17

Merged
merged 7 commits into from
Sep 2, 2023
Merged

Handle multiple station URLs on Register and more #17

merged 7 commits into from
Sep 2, 2023

Conversation

DaniElectra
Copy link
Member

  • Games like Mario Kart 7 or Mario Tennis Open set the local station and
    the public station. In these cases, use the public station given by the client.
  • Add the PID and RVCID on both stations, as they are required on NAT
    traversal and not all games will call ReportNATProperties to add them.
  • Implement MatchmakeExtension::CloseParticipation
  • and more

@DaniElectra
Handle multiple station URLs on Register
665c2b8 
Games like Mario Kart 7 or Mario Tennis Open set two station URLs on the
Register method, the local sattion and the public station. In these
cases, use the public station given by the client.

Also add the PID and RVCID on both stations, as they are required on NAT
traversal and not all games will call `ReportNATProperties` to add them.
@DaniElectra
Use sequential gathering IDs
61960be
@DaniElectra
Implement CloseParticipation
45027fb 
Called when a gathering fills up.
@DaniElectra
Various fixes
242bf55
jonbarrow
jonbarrow requested changes Sep 2, 2023
View reviewed changes
globals/matchmaking_globals.go Outdated Show resolved Hide resolved
secure-connection/register.go Outdated Show resolved Hide resolved
secure-connection/register.go Show resolved Hide resolved
@DaniElectra
Use NEX Counter for gathering IDs
07fa6d1
@DaniElectra
Search for public station on Register
eaecd44 
This is more reliable than just taking the second URL.
@DaniElectra
Better check for nil clients
d9bb79b 
EndParticipation triggered a nil client during testing. Add checks for
all client searches.
@jonbarrow jonbarrow merged commit d2d3440 into PretendoNetwork:main Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbarrow jonbarrow jonbarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniElectra @jonbarrow