Add common Ranking protocol #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on both Ultimate NES Remix and DKC:TF without issues
DaniElectra
requested changes
Oct 7, 2023
jonbarrow
requested changes
Oct 7, 2023
ranking/get_ranking.go
Outdated
| rmcResponse.SetError(nex.Errors.Ranking.NotFound) | ||
| } | ||
|
|
||
| if err == nil && totalCount != 0 { |
There was a problem hiding this comment.
With Dani's suggestion to change lines 25 and 29 into returns, this check would no longer be needed so long as the check on line 28 is split into 2 checks
There was a problem hiding this comment.
I'm a bit confused by "so long as the check on line 28 is split into 2 checks" :p
DaniElectra
reviewed
Oct 11, 2023
DaniElectra
approved these changes
Oct 11, 2023
|
LGTM 👍 |
jonbarrow
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on both Ultimate NES Remix and DKC:TF without issues