Fix MatchMaking function signatures and add Bytes() to MatchmakeParam #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And other minor changes
We didn't have support for writing maps before, but now that we do, implement the function. Also export the `Parameters` parameter on MatchmakeParam so that it can be modified outside nex-protocols-go
|
A new release of nex-go has been made. The module dependencies need to be updated as well. Other than that this looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have support for writing maps before, but now that we do,
implement the function.
Also export the
Parametersparameter onMatchmakeParamso that it canbe modified outside nex-protocols-go.
I also noticed that Yokai Watch 2 uses the
rttargument onReportNATTraversalResult, so it looks like the field was added on a NEXversion (and not just that it doesn't exist on 3DS).
Only the
MatchmakeParamchanges has been tested.Depends on PretendoNetwork/nex-go#30