Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntelliJ plugin: Add support for golden tests using alchemist package #846

Closed
DavidDWiser opened this issue Oct 29, 2024 · 4 comments · Fixed by #887
Closed

IntelliJ plugin: Add support for golden tests using alchemist package #846

DavidDWiser opened this issue Oct 29, 2024 · 4 comments · Fixed by #887
Assignees
@DavidDWiser @RomanovaPrime @PVGeorgievPrime
Labels
High Priority pgk:rx_bloc_intelij_plugin https://plugins.jetbrains.com/plugin/16165-rxbloc

Comments

@DavidDWiser
Copy link
Member

DavidDWiser commented Oct 29, 2024 •
edited
Loading

As a developer I want the plugin to be able to generate tests using the alchemist package as an ongoing effort to replace the discontinued golden_toolkit package. Support for the golden_toolkit tests will continue until announced otherwise.

ACs:

  • When generating tests, add a dropdown that would allow to select between two options: golden_toolkit and alchemist
  • The alchemist option should be preselected (and treated as the default one)
  • Existing functionality should remain untouched
  • Upon confirming, generate tests using the selected format

Estimate:

  • (TBA)
@DavidDWiser DavidDWiser converted this from a draft issue Oct 29, 2024
@DavidDWiser DavidDWiser added the pgk:rx_bloc_intelij_plugin https://plugins.jetbrains.com/plugin/16165-rxbloc label Oct 29, 2024
@DavidDWiser DavidDWiser mentioned this issue Oct 29, 2024
Open
8 tasks
@DavidDWiser DavidDWiser changed the title Add support for golden tests using alchemist package IntelliJ plugin: Add support for golden tests using alchemist package Oct 29, 2024
@StanevPrime
Copy link
Member

@PVGeorgievPrime, could you please provide an estimate for this ticket ?

PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Add support for golden tests using alchemist package
d71ef7f
PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Add unit test for the new template
eeb0c91
PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Fix failing bloc list generator test
49cebfb
PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Fix failing test
0dec016
PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Fix test file path
eb3c0fc
PVGeorgievPrime added a commit that referenced this issue Nov 19, 2024
@PVGeorgievPrime
#846 Add missing file
0de2e32
PVGeorgievPrime added a commit that referenced this issue Nov 20, 2024
@PVGeorgievPrime
#846 Add support for single file golden tests using alchemist package
052323a
@PVGeorgievPrime PVGeorgievPrime mentioned this issue Nov 20, 2024
Merged
@PVGeorgievPrime PVGeorgievPrime moved this from To Do to In Review in intelij_plugin Nov 20, 2024
@PVGeorgievPrime PVGeorgievPrime linked a pull request Nov 20, 2024 that will close this issue
Feature/846 alchemist golden test support #887
Merged
@github-project-automation github-project-automation bot moved this from In Review to Published in intelij_plugin Nov 25, 2024
@PVGeorgievPrime PVGeorgievPrime moved this from Published to Merged in intelij_plugin Nov 25, 2024
@StanevPrime
Copy link
Member

@DDavidPrime, could you please test the changes ?

@DavidDWiser
Copy link
Member Author

Confirming that it is working as expected. The newest version generates code for both alchemist and golden toolkit, depending on the selection.

@StanevPrime StanevPrime moved this from Tested to Merged in intelij_plugin Nov 28, 2024
@RomanovaPrime
Copy link
Contributor

Performed tests:

  • Generate golden test on a single file ending with “page” - successfully create folder with test and factory files
  • Trying to create tests for folder, but such exist - Provide user friendly message
  • Generate tests for feature folder prompt select a package for golden tests
  • alchemist package is preselected
  • Works for bought packages in a consistent way

@RomanovaPrime RomanovaPrime moved this from Merged to Tested in intelij_plugin Nov 28, 2024
@StanevPrime StanevPrime moved this from Tested to Published in intelij_plugin Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidDWiser DavidDWiser

@RomanovaPrime RomanovaPrime

@PVGeorgievPrime PVGeorgievPrime

Labels
High Priority pgk:rx_bloc_intelij_plugin https://plugins.jetbrains.com/plugin/16165-rxbloc
Projects
intelij_plugin
Status: Published
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/846 alchemist golden test support Prime-Holding/rx_bloc
4 participants
@StanevPrime @DavidDWiser @RomanovaPrime @PVGeorgievPrime