Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update todoapp goldens #873

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Conversation

DavidDWiser
Copy link
Member

Overview

Closes: #863

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
  • UI checked in Light / Dark mode

Stability

  • Checked if changes affect any features and verified affected features work as expected
  • Added unit tests for new code and verified existing tests work as expected

Code quality
- [ ] Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
- [ ] Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations
- [ ] If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (6226a1a) to head (834cb5b).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #873   +/-   ##
========================================
  Coverage    95.72%   95.72%           
========================================
  Files          121      121           
  Lines         2619     2619           
========================================
  Hits          2507     2507           
  Misses         112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DavidDWiser DavidDWiser reopened this Nov 18, 2024
Copy link
Member

@StanevPrime StanevPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable shadows for all golden tests

@DavidDWiser DavidDWiser merged commit 3681e01 into develop Nov 22, 2024
16 checks passed
@DavidDWiser DavidDWiser deleted the feat/update-todoapp-goldens branch November 22, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update golden tests with alchemist in Todo app
2 participants