Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/864 update goldens in reminder app with alchemist #902

Conversation

RomanovaPrime
Copy link
Contributor

@RomanovaPrime RomanovaPrime commented Nov 29, 2024

Overview

Closes: < #864 >

< Pull Request Description >

Checklist

Implementation

  • Implementation matches ticket acceptance criteria and technical notes
  • Manually tested against Acceptance Criteria
  • UI tests created in Light / Dark mode

Code quality

  • Updated CHANGELOG.md, README.md and package versions in pubspec.yaml
  • Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (c1344ec) to head (8c3ca1d).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #902   +/-   ##
========================================
  Coverage    95.72%   95.72%           
========================================
  Files          121      121           
  Lines         2619     2619           
========================================
  Hits          2507     2507           
  Misses         112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@StanevPrime StanevPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the golden files are pushed

@RomanovaPrime RomanovaPrime merged commit e824a6b into develop Dec 12, 2024
14 checks passed
@RomanovaPrime RomanovaPrime deleted the feature/864-update-goldens-in-reminder-app-with-alchemist branch December 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update golden tests with alchemist in Reminders app
3 participants