Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prism.languages.insertBefore overload #1505

Closed
RunDevelopment opened this issue Jul 29, 2018 · 0 comments · Fixed by #1631
Closed

Prism.languages.insertBefore overload #1505

RunDevelopment opened this issue Jul 29, 2018 · 0 comments · Fixed by #1631
Labels
enhancement

Comments

@RunDevelopment
Copy link
Member

RunDevelopment commented Jul 29, 2018 •
edited
Loading

insertBefore has a strange overload with two arguments where it just copies everything from before (which is used like insert) into a language definition.

This overload isn't documented anywhere well and I couldn't find any references to it in our code base.

Should we just remove it?
@RunDevelopment RunDevelopment mentioned this issue Nov 23, 2018
Merged
mAAdhaTTah pushed a commit that referenced this issue Dec 1, 2018
@RunDevelopment @mAAdhaTTah
Remove unused insertBefore overload (#1631)
39686e1 
Mentioned in #1505.
ggrossetie pushed a commit to ggrossetie/prism that referenced this issue Mar 11, 2019
@RunDevelopment @ggrossetie
Remove unused insertBefore overload (PrismJS#1631)
67b9157 
Mentioned in PrismJS#1505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed unused insertBefore overload RunDevelopment/prism
2 participants
@mAAdhaTTah @RunDevelopment