-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pacaligo: adding support for pascaligo, http://ligolang.org #1947
Conversation
@DefinitelyNotAGoat Thank you for making this PR. However, I have a little question: Isn't this language definition basically the combination of PascalLIGO and CameLIGO which are two languages with different syntax? And a small note: the tests failed because I'll do the full review soon. |
Thanks @RunDevelopment! So this is actually the pascaligo version so I will edit to make sure that's noted, rebuild and push. |
50990d3
to
f1b1188
Compare
Rebuilt, and pushed name changes to accurately reflect pascaligo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DefinitelyNotAGoat Thank you for the clarification!
I left you a few comments.
Also could you please add an example page showing off the main features of the language? (Something like this)
Apart from these two things, really solid work! I'll be looking forward to the final result!
f1b1188
to
1cedf27
Compare
Merge branch 'master' into master.
6348d2b
to
d06bcde
Compare
@RunDevelopment thanks for the review. I added some new changes to correct the issues. Let me know if you need anything else! |
d06bcde
to
06fae47
Compare
Requests include regex improvements, and formatting. Merge branch 'master' into master.
06fae47
to
99cc192
Compare
Thanks for the tips @RunDevelopment! I re-pushed new changes to reflect the change requests. |
Nice! |
Pascaligo improvements
I think this is ready. Thank you for contributing @DefinitelyNotAGoat! |
Summary
This PR adds the language definition for pascaligo, a layer 2 smart contract language for the Tezos blockchain.
http://ligolang.org