-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEDCOM: Update tag
to record
#3386
Conversation
Hmmm, we don't disallow this right now, but using two standard tokens can cause problems for themes. If a token uses two standard tokens, then the token with have the color of the CSS rule that is defined last. E.g. <style>
.token.tag { color: red; }
.token.string { color: blue; }
</style>
<!-- Since `.token.string` is defined last, this token will be blue. -->
<span class="token tag string">foo</span>
<!-- This token will also be blue. -->
<span class="token string tag">bar</span> This behavior is technically well-defined (it's simply how CSS works), but I doubt that theme authors will expect this. Honestly, I'm not sure whether using two standard tokens should simply be discouraged and avoided when possible, or whether we should disallow it completely (adding a test for this would be easy). What do you think? |
That's a good point! I guess I will remove the Hmm, I'm not really sure whether we should disallow it completely. There is still the question of what we should do with tokens that qualify as both |
Sounds good to me.
Yeah... This will be difficult. If we disallowed multiple standard tokens, then we could just say that |
Alrighty! I wonder how composite tokens would fit into this too, but maybe that's separate enough (non-standard + standard compared to standard + standard that we have here). Maybe having multiple standard token aliases could be disallowed at least, but I'm not sure if there are any instances where that could make sense yet. |
In the GEDCOM 5.5.5 specification,
tag
has been updated torecord
:Screenshot
I've kept
tag
as an alias since some may be using the older specs. However, I'm not sure ifstring
should be kept as an alias, sincetag
is also a standard token.