Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for css and data attributes that correctly declare and generate inputs and outputs. Support Pandoc --standalone and --self-contained #16

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add support for css and data attributes that correctly declare and generate inputs and outputs. Support Pandoc --standalone and --self-contained #16

wants to merge 10 commits into from

Conversation

deedf
Copy link

@deedf deedf commented Feb 11, 2020

This is based on #13 but fixes the issues pending there, it also adds a "data" attribute that can be used to declare stuff like images and other media referenced in the doc, and have them copied over as runfiles,

@deedf deedf changed the title Add support for css and data attributes that correctly declare and generate inputs and outpus Add support for css and data attributes that correctly declare and generate inputs and outputs Feb 11, 2020
@deedf deedf mentioned this pull request Feb 11, 2020
Open
ozio85
ozio85 reviewed Aug 2, 2020
View reviewed changes
pandoc.bzl Outdated Show resolved Hide resolved
ozio85
ozio85 reviewed Aug 2, 2020
View reviewed changes
pandoc.bzl Outdated Show resolved Hide resolved
@deedf
Copy link
Author

deedf commented Aug 2, 2020

Hey thanks for looking at this, I had kind of given up on getting traction here and forgot to update this PR with my later fixes. It is updated now.

@deedf
Copy link
Author

deedf commented Aug 2, 2020

It is an almost complete rewrite of the CSS support with added support for the pandoc standalone and --self-contained flags.

@deedf deedf changed the title Add support for css and data attributes that correctly declare and generate inputs and outputs Add support for css and data attributes that correctly declare and generate inputs and outputs. Support Pandoc --standalone and --self-contained Aug 2, 2020
dmadisetti
dmadisetti approved these changes Dec 12, 2020
View reviewed changes
Copy link

@dmadisetti dmadisetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewing in the hopes than this project might see a bit more traction. Only other thing is I was say add a test to the samples folder

pandoc.bzl Show resolved Hide resolved
pandoc.bzl Show resolved Hide resolved
pandoc.bzl Show resolved Hide resolved
pandoc.bzl Show resolved Hide resolved
@dmadisetti
Copy link

Ping @ProdriveTechnologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmadisetti dmadisetti dmadisetti approved these changes

@ozio85 ozio85 ozio85 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deedf @dmadisetti @ozio85