-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify _log_input_summary function #7811
Open
hyacinth97223
wants to merge
20
commits into
Project-MONAI:dev
Choose a base branch
from
hyacinth97223:fix-issue-7513
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
bf9db2c
Modify _log_input_summary function
hyacinth97223 7f2633e
Modify "_log_input_summary" function
hyacinth97223 aa3d6ac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bacd791
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 0c7857a
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 60b9947
modify _log_input_summary function.
hyacinth97223 4fe7d52
Merge branch 'fix-issue-7513' of https://github.com/hyacinth97223/MON…
hyacinth97223 1fda340
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 93ad7a5
fix: auto-fix imports in scripts.py
hyacinth97223 930ce2c
fix: auto-fix imports in scripts.py
hyacinth97223 c55e9c7
fix: auto-fix imports in scripts.py
hyacinth97223 d914f4e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dec4b0c
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 e7fcd41
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 9440c80
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 43ca23d
Fix log_input_summary function
hyacinth97223 7eb7b79
Merge branch 'fix-issue-7513' of https://github.com/hyacinth97223/MON…
hyacinth97223 a9507ad
Merge branch 'Project-MONAI:dev' into fix-issue-7513
hyacinth97223 69001d7
Fix log_input_summary
hyacinth97223 a4ae330
Merge branch 'fix-issue-7513' of https://github.com/hyacinth97223/MON…
hyacinth97223 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change may still not solve the issue mentioned in #7513?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it seems to me will happen here is the message will be written all at once with one call to
logger.info()
which has a greater chance of appearing all at once in the output in the presence of multiple GPUs. This is only by chance and isn't guaranteed. What we need in the case of multiple GPUs is to identify which process is rank 0 and only it writes to the logger by default but with an option to allow everyone to write if desired. With thetorch.distributed
package this would be:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericspod Thanks for your advise. I will try it.