Fix ImageFilter to allow Gaussian filter without filter_size #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KumoLiu
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks for the PR, LGTM.
Could you please help sign off to solve the DCO error: https://github.com/Project-MONAI/MONAI/pull/8189/checks?check_run_id=32499106258?
EloiNavet
force-pushed
the
fix-imagefilter-gaussian
branch
from
97204c5 to
82715cb
Compare
Fixes Project-MONAI#8127 Update `ImageFilter` to handle Gaussian filter without requiring `filter_size`. * Modify `monai/transforms/utility/array.py` to allow Gaussian filter without `filter_size`. - Adjust `_check_filter_format` method to skip `filter_size` check for Gaussian filter. Indeed Gauss filter is the only one in the list that doesn't require a filter_size. * Add unit test in `tests/test_image_filter.py` for Gaussian filter without `filter_size`. - Verify output shape matches input shape. Note that this method is compliant with the dictionnary version since this one load the fixed version. Signed-off-by: Eloi Navet <[email protected]>
To satisfy the linter Signed-off-by: Eloi <[email protected]> Signed-off-by: Eloi Navet <[email protected]>
I, Eloi <[email protected]>, hereby add my Signed-off-by to this commit: 79e8aa0 Signed-off-by: Eloi <[email protected]> Signed-off-by: Eloi Navet <[email protected]>
I, Eloi [email protected], hereby add my Signed-off-by to this commit: 79e8aa0 Signed-off-by: Eloi [email protected] Signed-off-by: Eloi Navet <[email protected]>
I, Eloi Navet <[email protected]>, hereby add my Signed-off-by to this commit: 82715cb Signed-off-by: Eloi Navet <[email protected]>
EloiNavet
force-pushed
the
fix-imagefilter-gaussian
branch
from
1fecaac to
fb5be1c
Compare
ericspod
approved these changes
Nov 6, 2024
|
/build |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8127
Update
ImageFilterto handle Gaussian filter without requiringfilter_size.monai/transforms/utility/array.pyto allow Gaussian filter withoutfilter_size._check_filter_formatmethod to skipfilter_sizecheck for Gaussian filter. Indeed Gauss filter is the only one in the list that doesn't require a filter_size.tests/test_image_filter.pyfor Gaussian filter withoutfilter_size.Note that this method is compliant with the dictionnary version since this one load the fixed version.
Signed-off-by: Eloi [email protected]