Fix all style/type errors in existing code #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
force-pushed
the
fix_type_errors
branch
from
10cf937 to
0081d49
Compare
MMelQin
reviewed
Sep 11, 2021
MMelQin
reviewed
Sep 11, 2021
MMelQin
reviewed
Sep 11, 2021
MMelQin
reviewed
Sep 11, 2021
MMelQin
reviewed
Sep 11, 2021
MMelQin
approved these changes
Sep 11, 2021
Signed-off-by: Gigon Bae <[email protected]>
Existing implementation did not set attributes in advance, and their availability are checked by handing AttributeError. For the reason, initializing those attributes with None caused spleen app execution failure. (All metadata dictionary in Domain class is filled with None even for non-available attributes) With this patch, the attribute's availability is checked by checking if its value is None and getters return None if attributes are not set (using getattr() method). Signed-off-by: Gigon Bae <[email protected]>
gigony
force-pushed
the
fix_type_errors
branch
from
0081d49 to
b0ad0ee
Compare
|
Thanks for reviewing the comments and making enhancements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all errors during
./run check -f.Fix all type errors in existing code (c65066c)
Fix DICOM attribute handling (b0ad0ee)
Existing implementation did not set attributes in
advance, and their availability are checked by
handing AttributeError.
For the reason, initializing those attributes with
None caused spleen app execution failure.
(All metadata dictionary in Domain class is filled
with None even for non-available attributes)
With this patch, the attribute's availability is checked
by checking if its value is None and getters return
None if attributes are not set (using getattr() method).