-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change loss function in the reconstruction tutorial. #1349
Comments
Hi @Can-Zhao , Thanks, |
that's discussed here Project-MONAI/MONAI#6267 (comment) |
Signed-off-by: Wenqi Li <[email protected]>
I think one way to fix it is to create the loss later in the pipeline #1351 (untested) |
Fixes #1349 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Wenqi Li <[email protected]>
Fixes Project-MONAI#1349 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Wenqi Li <[email protected]>
Describe the bug
Because of this PR, there is a breaking change in the
SSIMLoss
. Unfortunatelly, this loss is used in the varnet reconstruction demo . Therefore, this tutorial must be updated according to this change.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Start to train.
Screenshots
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: