Compute correct speed values in tile plugin #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
approved these changes
Mar 9, 2017
| @@ -568,14 +596,15 @@ void encodeVectorTile(const datafacade::ContiguousInternalMemoryDataFacadeBase & | |||
|
|
|||
| // Calculate the speed for this line | |||
| std::uint32_t speed_kmh = | |||
| static_cast<std::uint32_t>(round(length / reverse_weight * 10 * 3.6)); | |||
| static_cast<std::uint32_t>(round(length / reverse_duration * 10 * 3.6)); | |||
There was a problem hiding this comment.
If statement above needs to be adjusted as well, it check for zero division.
| @@ -544,14 +571,15 @@ void encodeVectorTile(const datafacade::ContiguousInternalMemoryDataFacadeBase & | |||
|
|
|||
| // Calculate the speed for this line | |||
| std::uint32_t speed_kmh = | |||
| static_cast<std::uint32_t>(round(length / forward_weight * 10 * 3.6)); | |||
| static_cast<std::uint32_t>(round(length / forward_duration * 10 * 3.6)); | |||
There was a problem hiding this comment.
If statement above needs to be adjusted as well, it check for zero division.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In #2399 tile plugin was not adjusted and returned weight-based speed values that look misleading if profile weight is not duration.
PR fixes speed to be
distance / duration, addsweightfeature and fixes turn durations./cc @TheMarex
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?