Add OSM node barrier=height_restrictor handling #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
force-pushed
the
barrier/height_restrictor
branch
from
8e728a9 to
448c7e3
Compare
oxidase
force-pushed
the
barrier/height_restrictor
branch
from
448c7e3 to
c4efbbe
Compare
TheMarex
added
Review - In feedback
Ready To Merge
and removed
Review
Review - In feedback
labels
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Jun 10, 2018
- Changes from 5.15.2:
- Guidance
- ADDED Project-OSRM#4676: Support for maneuver override relation, allowing data-driven overrides for turn-by-turn instructions [Project-OSRM#4676](Project-OSRM#4676)
- CHANGED Project-OSRM#4830: Announce reference change if names are empty
- CHANGED Project-OSRM#4835: MAXIMAL_ALLOWED_SEPARATION_WIDTH increased to 12 meters
- CHANGED Project-OSRM#4842: Lower priority links from a motorway now are used as motorway links [Project-OSRM#4842](Project-OSRM#4842)
- CHANGED Project-OSRM#4895: Use ramp bifurcations as fork intersections [Project-OSRM#4895](Project-OSRM#4895)
- CHANGED Project-OSRM#4893: Handle motorway forks with links as normal motorway intersections[Project-OSRM#4893](Project-OSRM#4893)
- FIXED Project-OSRM#4905: Check required tags of `maneuver` relations [Project-OSRM#4905](Project-OSRM#4905)
- Profile:
- FIXED: `highway=service` will now be used for restricted access, `access=private` is still disabled for snapping.
- ADDED Project-OSRM#4775: Exposes more information to the turn function, now being able to set turn weights with highway and access information of the turn as well as other roads at the intersection [Project-OSRM#4775](Project-OSRM#4775)
- FIXED Project-OSRM#4763: Add support for non-numerical units in car profile for maxheight [Project-OSRM#4763](Project-OSRM#4763)
- ADDED Project-OSRM#4872: Handling of `barrier=height_restrictor` nodes [Project-OSRM#4872](Project-OSRM#4872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Nodes with
barrier=height_restrictortags are not handled incar.luaprofile, for example, a barrier node leads to a detour with misleading instructions:http://map.project-osrm.org/?z=17¢er=48.075609%2C11.099442&loc=48.074136%2C11.092565&loc=48.075369%2C11.102929&hl=en&alt=0
PR adds
height_restrictortag tobarrier_whitelistand a check ofmaxheighttag inprocess_nodefunction. Also PR addsget_location_tagmethod to theosmium::Nodeinterface.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?