Lithuanian street classifications update #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryleb
force-pushed
the
lt-abbr-fix
branch
3 times, most recently
from
d61f9eb to
d6695fc
Compare
1ec5
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Also Lithuanian OSM community uses already abbreviated street names in most cases and so proposed changes could be easily verified
That’s a little surprising in light of the rule against abbreviations in OSM. Nonetheless, I agree that we should try to match whatever abbreviations the OSM community happens to use explicitly, since they’re the experts. Thank you for these changes.
1ec5
added a commit
that referenced
this pull request
Jul 19, 2018
- Updated French localization with articles and prepositions insertion using grammar rules. #252 - Added a Burmese localization. #247 - Added a Finnish localization. #239 - Added a Korean localization. #243 - Updated translations in Simplified Chinese. #233 #248 - Updated Russian grammar with 'chord' status street name. #245 - Added Russian church names abbreviations. #237 - Corrected Lithuanian streets abbreviations. #238
1ec5
added a commit
that referenced
this pull request
Jul 19, 2018
- Updated French localization with articles and prepositions insertion using grammar rules. #252 - Added a Burmese localization. #247 - Added a Finnish localization. #239 - Added a Korean localization. #243 - Updated translations in Simplified Chinese. #233 #248 - Updated Russian grammar with 'chord' status street name. #245 - Added Russian church names abbreviations. #237 - Corrected Lithuanian streets abbreviations. #238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Actually I don't speak Lithuanian but spent a lot of time to investigate European street status names for my Garmin TTS voices update project.
And my investigation shows that Lithuanian streets have different abbreviations than currently specified ones in
languages/abbreviations/lt.json. Also Lithuanian OSM community uses already abbreviated street names in most cases and so proposed changes could be easily verified:Non-street abbreviations were moved from
classificationsblock toabbreviationsand sorted.Tasklist