Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve article matching in French instructions #279

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Improve article matching in French instructions #279

merged 2 commits into from
Mar 27, 2019

Conversation

yuryleb
Copy link
Contributor

@yuryleb yuryleb commented Mar 27, 2019 •
edited
Loading

Issue

Match articles in French instructions with any number of whitespaces between article and {waypoint_name} to fix #275 issue.

Tasklist

  • Add changelog entry
  • Test with osrm-frontend (?)
  • Review

@1ec5, should I update change log for this 1 char change in French override script?

@yuryleb
Copy link
Contributor Author

yuryleb commented Mar 27, 2019

Change log was also updated.

danpaz
danpaz approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@danpaz danpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @yuryleb

@1ec5 1ec5 merged commit 4a3bc26 into Project-OSRM:master Mar 27, 2019
@yuryleb yuryleb deleted the fr-grammar-article-fix branch March 28, 2019 08:28
@kevinkreiser kevinkreiser mentioned this pull request Mar 29, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@danpaz danpaz danpaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra à in french waypoint_name arrival instruction
3 participants
@yuryleb @1ec5 @danpaz