-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese translations and add named intersections #290
Conversation
@@ -21,7 +21,7 @@ | |||
"hu": "Hajtson az átkötő útszakaszra balról", | |||
"id": "Ambil jalan yang melandai di sebelah kiri", | |||
"it": "Prendi la rampa a sinistra", | |||
"ja": "左方向のランプに向かう", | |||
"ja": "左方向、出口です", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"左方向、出口に向かう" is better
"左方向、出口です" means "there is an exit on the left"
"exit": "{exit}出口に向かう", | ||
"exit_destination": "{exit}出口を出て{destination}へ向かう" | ||
"default": "出口です", | ||
"name": "{way_name}方面、出口です", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"{way_name}方面、出口に向かう" is better
"{way_name}方面、出口です" means "there is an exit on the {way_name}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably just replace 出口です with 出口に向かう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe many of Japanese Navigation system will say "出口です” followed with "右側車線を進んでください"(take right lane). @danpaz we may need to get more user research if you are uncertain for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tichimura that is good to know about combining 出口です with lane instructions. This project doesn't support lanes yet, so we could not distinguish between a road with one lane or multiple. At this time it sounds like @tsuz's suggestion to replace all instances of 出口です with 出口に向かう would be the next best option. Do you agree with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tichimura has a great point since he has done more extensive comparison with other car navigations. "出口です" seems to be standard among other navs whereas my suggestion was to keep the format standardized among other strings. So, whichever is fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks both, I kept the original phrasing for off ramp (出口です) and on ramp (入口です).
But what's about updating strings on Transifex? |
Issue
Updates ramp and exit instructions for the Japanese localization, courtesy of @tichimura. These changes were based on feedback from @tsuz who noted the "rampu" phrases sounded unnatural.
@tsuz @YoshiYazawa for review.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?