Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX - Realtor-restricted tabs require a resource restart #28

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

Martinator9001
Copy link
Contributor

@Martinator9001 Martinator9001 commented Aug 19, 2023

(that was a lot of R's)

Overview

This PR fixes the problem with ps-realtor's realtor tabs only working after a resource restart after the given user has loaded in.

Details

Essentially copied what ps-realtor does when the resource starts, and pasted it to also do it when a player loads in.

UI Changes / Functionality

Tabs now work without restarting the resource
image

Testing Steps

Before:
Start server, Load in, open /housing - no tabs. Restart ps-realtor - tabs appear.
After:
Start server, load in, open /housing - tabs appear.

  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

@Martinator9001
Copy link
Contributor Author

I think that the problem happened due to the commit merge from bl-realtor, since that's when the problem appeared IIRC

@Martinator9001
Copy link
Contributor Author

Tried it out with the realtor in my server and there weren't any bugs with the tabs

@Martinator9001 Martinator9001 changed the title BUGFIX - Realtor-restricted tabs require an resource restart BUGFIX - Realtor-restricted tabs require a resource restart Aug 22, 2023
@MonkeyWhisper MonkeyWhisper merged commit 84de52d into Project-Sloth:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants