Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiviSEPA hides invoice button for contributions #356

Closed
ghost opened this issue Jan 12, 2016 · 7 comments
Closed

CiviSEPA hides invoice button for contributions #356

ghost opened this issue Jan 12, 2016 · 7 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jan 12, 2016

As of version 4.6, CiviCRM supports the creation of invoices for contributions. This is not possible, when the CiviSEPA module is active, because it overwrites /templates/CRM/Contribute/Form/ContributionView.tpl which is based on an old version (4.3) that does not contain all template changes.

diff file:
ContributionView.txt

@ghost ghost added the bug label Jan 12, 2016
@bjendres bjendres added this to the 1.2.2 milestone Jan 13, 2016
@bjendres
Copy link
Member

Yes, we definitely need to change this asap. I didn't know that was in there.

@tttp: This is still some of your code, right? Can you remember why you included this in the first place?

@magnolia61
Copy link
Contributor

When I remove /templates/CRM/Contribute/Form/ContributionView.tpl from CiviSEPA the invoice buttons return and I still get the button with the mandate options in civicrm 4.6.9. Happy with that!
So unless Xavier remembers the initial inclusion I believe it is safe to delete this file.

@tttp
Copy link
Member

tttp commented Jan 15, 2016

I think I remember and was a temporary fix... that has long been fixed in
the core and is past its due date indeed.

One less file, me like it!

On 15 January 2016 at 13:09, Richard van Oosterhout <
[email protected]> wrote:

When I remove /templates/CRM/Contribute/Form/ContributionView.tpl from
CiviSEPA the invoice buttons return and I still get the button with the
mandate options in civicrm 4.6.9. Happy with that!
So unless Xavier remembers the initial inclusion I believe it is safe to
delete this file.


Reply to this email directly or view it on GitHub
#356 (comment)
.

bjendres added a commit that referenced this issue Jan 15, 2016
@bjendres bjendres modified the milestones: 1.3, 1.2.2 Jan 15, 2016
@bjendres
Copy link
Member

aaaand it's gone. Makes me happy as well :)

@Fabian-SYSTOPIA
Copy link

It seems like this bug is back - using 4.6.24 and CiviSEPA 1.2.4beta1

@bjendres
Copy link
Member

Seems to be related to the invoicing functions.

@bjendres bjendres reopened this Apr 11, 2017
@bjendres bjendres modified the milestones: 1.2.5, 1.3 Apr 11, 2017
@bjendres
Copy link
Member

bjendres commented Oct 2, 2017

released with 1.2.5.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants