Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 compatibility: Error: Call to undefined function split() #411

Closed
magnolia61 opened this issue Nov 29, 2016 · 6 comments
Closed

PHP7 compatibility: Error: Call to undefined function split() #411

magnolia61 opened this issue Nov 29, 2016 · 6 comments
Milestone

Comments

@magnolia61
Copy link
Contributor

Thanks for the 1.2.4 beta1 release. Just tried it on drupal 7.5.2 civicrm 4.7.13 and PHP7
Using the civisepa admin settings I get the following error when saving the default values:

Error: Call to undefined function split() in CRM_Sepa_Logic_Settings::getListSetting() (line 86 of /home/xyz/domains/ourdomain.nl/public_html/sites/all/modules/civicrm_extensions/org.project60.sepa/CRM/Sepa/Logic/Settings.php).

Somewhere I found that for PHP7 the split function is deprecated and explode can be used instead.
Just reporting FYI ;-)

@tttp
Copy link
Member

tttp commented Nov 29, 2016

Hi,

Thanks for the report. Is the rest of civi working in PHP7?
the latest update I have was that it relies on several key libraries (eg pear ones) that aren't compatible with PHP7

@magnolia61
Copy link
Contributor Author

magnolia61 commented Nov 29, 2016

drupal& civicrm Working flawlessly in production for a month now, using even registrations and contributions. And: all much faster! So would be nice of CiviSEPA becomes PHP7 ready.

@bjendres
Copy link
Member

@magnolia61: Thanks for the report. Care to share you patch?

@bjendres bjendres modified the milestone: 1.2.5 Nov 29, 2016
@magnolia61
Copy link
Contributor Author

magnolia61 commented Nov 29, 2016

I have no patch, just reporting. I read something on changing the split for explode but I'm not much of a coder myself :-(

@adanielvv
Copy link
Contributor

adanielvv commented Jul 5, 2017

Works for me: 1.2.5.alpha1 on https://github.com/Project60/org.project60.sepa/releases

@bjendres
Copy link
Member

Released with 1.2.5.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants