Fix inconsistent formatting and validation of IBAN/BIC #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some inconsistencies in the way IBANs and BICs are formatted and validated in different components. The main issue was that IBANs for PSP creditors would be formatted according to SEPA/IBAN logic (i.e. uppercase, remove spaces), which causes issues for case-sensitive PSPs. Instead, this is now only applied for SEPA creditors. The IBAN/BIC formatting was moved to a central function to DRY up the code. The formatting is now also applied consistently e.g. in the new mandate form, where previously a lower-case IBAN would've been rejected as invalid. This also contains some whitespace cleanup that my IDE seems to insist on.
|
Thanks @pfigel |
|
Will be released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some inconsistencies in the way IBANs and BICs are formatted and validated in different components. The main issue was that IBANs for PSP creditors would be formatted according to SEPA/IBAN logic (i.e. uppercase, remove spaces), which causes issues for case-sensitive PSPs. Instead, this is now only applied for SEPA creditors.
The IBAN/BIC formatting was moved to a central function to DRY up the code. The formatting is now also applied consistently e.g. in the new mandate form, where previously a lower-case IBAN would've been rejected as invalid.
This also contains some whitespace cleanup that my IDE seems to insist on.