Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generatePDF docs, remove first parameter default #679

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add generatePDF docs, remove first parameter default #679

merged 1 commit into from
Jul 26, 2023

Conversation

bjendres
Copy link
Member

No description provided.

@bjendres bjendres added this to the 1.10 milestone Jul 25, 2023
@bjendres
Copy link
Member Author

Avoids the following error:

[PHP Deprecation] Optional parameter $send declared before required parameter $template_id is implicitly treated as a required parameter at /var/www/vhosts/[redacted]/httpdocs/pro/drupal/web/sites/default/files/civicrm/ext/org.project60.sepa/CRM/Sepa/Page/SepaMandatePdf.php:153

@bjendres bjendres requested a review from jensschuppe July 25, 2023 15:26
@bjendres
Copy link
Member Author

@jensschuppe any objections?

@bjendres bjendres merged commit 17c5c12 into master Jul 26, 2023
@bjendres
Copy link
Member Author

thanks @jensschuppe

@bjendres bjendres deleted the issue/parameter_send_declared_before_required_parameter branch December 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensschuppe jensschuppe jensschuppe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@bjendres @jensschuppe