Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 1042 update NodeJS custom loaders implementation #1043

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 15, 2023

Related Issue

resolves #1042

Summary of Changes

  1. Explicitly forward to our custom resolve function in test-loader.js (this revealed the issue within the project)
  2. Fix to support latest experimental custom loaders NodeJS API design by using parentURL

@thescientist13 thescientist13 added bug Something isn't working documentation Greenwood specific docs CLI SSR labels Jan 15, 2023
@thescientist13 thescientist13 changed the title Bug/issue 1042 update ssr custom loaders implementation Bug/issue 1042 update NodeJS custom loaders implementation Jan 15, 2023
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Jan 18, 2023
@thescientist13 thescientist13 removed the documentation Greenwood specific docs label Jan 18, 2023
@thescientist13 thescientist13 merged commit ed9077a into master Jan 19, 2023
@thescientist13 thescientist13 deleted the bug/issue-1042-update-SSR-custom-loaders-implementation branch January 19, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid URL when using SSR custom imports
1 participant