feature/issue 1328 customize Vercel adapter serverless runtime nodejs version #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
thescientist13
force-pushed
the
feature/issue-1328-customizable-serverless-runtime-nodejs-version
branch
from
c05a040 to
67c4635
Compare
thescientist13
changed the title
thescientist13
commented
Nov 28, 2024
There was a problem hiding this comment.
Looks like we were able to stay on Node 18 in #1326 , so we should reset the default version back to nodejs18.x
40 tasks
thescientist13
changed the title
thescientist13
commented
Dec 31, 2024
There was a problem hiding this comment.
Based on #1372 / #1373 it looks like we can keep the minimum version for Greenwood as 18.x, but not sure if that's useful to what people are using? Given where NodeJS is in the LTS cycle, perhaps 20.x makes sense, right in the middle?
Mostly just thinking of this from what makes a good default value for this plugin? Or just always keep it aligned with Greenwood's minimum version for consistency? 🤔
thescientist13
force-pushed
the
feature/issue-1328-customizable-serverless-runtime-nodejs-version
branch
from
67c4635 to
8b39287
Compare
thescientist13
deleted the
feature/issue-1328-customizable-serverless-runtime-nodejs-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1329
Documentation
N / A
Summary of Changes
nodejs20.xTODO
20.x(latest LTS) #1202 / enhancement/issue 1317 import map generation refactor for exports and leveragingimport.meta.resolve#132620.xfor now, actually - feature/issue 1328 customize Vercel adapter serverless runtime nodejs version #1330 (review)