-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Include Plugin #712
Merged
Merged
HTML Include Plugin #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
RFC
Proposal and changes to workflows, architecture, APIs, etc
discussion
tied to an ongoing discussion or meeting notes
labels
Sep 1, 2021
thescientist13
changed the title
spike for RFC discussion around html inclue support
spike for RFC discussion around html include support
Sep 1, 2021
This comment has been minimized.
This comment has been minimized.
5 tasks
thescientist13
force-pushed
the
rfc/plugin-include-html
branch
from
November 4, 2021 15:42
12fb8c8
to
d5b3ed8
Compare
thescientist13
changed the title
spike for RFC discussion around html include support
HTML Includes Plugin
Nov 4, 2021
thescientist13
added
documentation
Greenwood specific docs
feature
New feature or request
Plugins
Greenwood Plugins
website
Tasks related to the projects website / documentation
labels
Nov 4, 2021
Interesting observation but I noticed while working on this PR that on the main site, the (font?) size of the footer is slightly smaller on the home page vs any of the other pages / templates. Not sure if just me? cc: @aholtzman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discussion
tied to an ongoing discussion or meeting notes
documentation
Greenwood specific docs
feature
New feature or request
Plugins
Greenwood Plugins
RFC
Proposal and changes to workflows, architecture, APIs, etc
website
Tasks related to the projects website / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #788
Summary of Changes
Interesting observation about the footer here
TODO
Going further, would like to see how far we can take it if we were to support something like this (notice the .js extension)
Then the plugin could just
import
from that file and statically stamp out the contents that way? 🤔