CommonJS distribution bundle #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
thescientist13
commented
Jun 20, 2022
| @@ -4,8 +4,7 @@ import './dom-shim.js'; | |||
| import * as acorn from 'acorn'; | |||
| import * as walk from 'acorn-walk'; | |||
| import { parse, parseFragment, serialize } from 'parse5'; | |||
|
|
|||
| import fs from 'node:fs/promises'; | |||
| import fs from 'fs/promises'; | |||
There was a problem hiding this comment.
Dropped node: for better backwards support for now, of Node >= 14.x
thescientist13
commented
Jun 21, 2022
| @@ -105,10 +104,11 @@ async function getTagName(moduleURL) { | |||
| async function initializeCustomElement(elementURL, tagName, attrs = []) { | |||
| await registerDependencies(elementURL); | |||
|
|
|||
| const { pathname } = elementURL; | |||
There was a problem hiding this comment.
Avoiding direct use of import(elementURL) since when converted to CJS, require will break when given a URL.
If 11ty moves to ESM, then we could remove this, but might be nice for general CJS <> ESM interop.
thescientist13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
In support of integrating with CJS based projects like Eleventy, using Rollup to provide a temporary "dist" version of WCC for projects that can't support ESM directly.
Summary of Changes
distcommand to generate a single bundle ofwccprepublishscript to make sure it gets run on each publish