Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a regression where companion window would not scroll #2921

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

mejackreed
Copy link
Collaborator

Fixes a bug introduced in #2907

This was due to an update in react-rnd, introduced in v10.1.1, by updating re-resizable bokuweb/react-rnd@c3fa43f

This was due to an upstream bug fix in re-resizable that sets flexShrink: 0 for the parent div without a way to override it. https://github.com/bokuweb/re-resizable/pull/541/files

@mejackreed mejackreed force-pushed the fix-scroll-regression branch from 56709de to b1921c8 Compare December 19, 2019 23:58
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #2921 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2921   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files         157      157           
  Lines        2344     2344           
=======================================
  Hits         2185     2185           
  Misses        159      159
Impacted Files Coverage Δ
src/components/CompanionWindow.js 93.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f67b46...b1921c8. Read the comment docs.

@jkeck jkeck merged commit 4606679 into master Dec 20, 2019
@jkeck jkeck deleted the fix-scroll-regression branch December 20, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants