Bug fix: viewer not scrolling to toc entry correctly #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3926 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 313 313
Lines 14767 14787 +20
Branches 2496 2496
=======================================
+ Hits 13958 13978 +20
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. |
gerdesque
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just fixed a bug. This is related to the table of contents and the ScrollTo component.
Previously, an empty containerRef was passed to it inital, which meant that it did not scroll to the correct position in the TOC.
I used this config prop:
windows: [{ manifestId: "https://iiif.ub.uni-leipzig.de/0000034390/manifest.json", canvasIndex: 330,}]for testing.