Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert projectmirador/mirador to a monorepo #3984

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Convert projectmirador/mirador to a monorepo #3984

wants to merge 1 commit into from

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 12, 2024

A monorepo (pulling in mirador, mirador-annotations, -image-tools, etc) may make it easier to develop and maintain core plugins. It may also make it easier to manage some of the core mirador components if we extract additional packages for e.g. the window, workspace, etc pieces with clearly defined boundaries between the different pieces.

TODOs:

  • convert webpack to vite (proposed).
  • convert jest to vitest (jest doesn't seem to play too nice with the monorepo setup)
  • ??

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (05194d8) to head (6d507bd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3984   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         313      313           
  Lines       14767    14767           
  Branches     2496     2496           
=======================================
  Hits        13958    13958           
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeer cbeer force-pushed the monorepo branch 4 times, most recently from 9558482 to 6d507bd Compare December 19, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant