Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin python<3.13 #37

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Pin python<3.13 #37

merged 2 commits into from
Nov 15, 2024

Conversation

ktyle
Copy link
Collaborator

@ktyle ktyle commented Nov 15, 2024

Resolves #36

@ktyle ktyle requested a review from brian-rose November 15, 2024 16:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 9d24589
✅ Deployment Preview URL: https://ProjectPythia.github.io/HRRR-AWS-cookbook/_preview/37

brian-rose
brian-rose approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I just suggested adding a comment about the version pin (which we should be able to remove when we go to JupyterBook 2.0)

environment.yml Outdated Show resolved Hide resolved
@ktyle @brian-rose
Update environment.yml
fefc208 
Co-authored-by: Brian Rose <[email protected]>
@ktyle ktyle merged commit d09ccf8 into ProjectPythia:main Nov 15, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
@ktyle @github-actions
Delete preview for pull request \#37
2d4838e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-rose brian-rose brian-rose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build is failing with out-of-date Sphinx version
2 participants
@ktyle @brian-rose