Show name of the player that invited you to a group instead of %TT #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GroupEventType enum constants, because grouping is implied
…roupService claims it should be -1 but it's 0 when server initializes
…be the object ID for the CREO that sent the invitation and not the object ID for the GRUP
madsboddum
added
IMPROVEMENT
Josh-Larson
reviewed
Jul 8, 2022
src/main/java/com/projectswg/holocore/services/gameplay/player/group/GroupService.kt
Outdated
Show resolved
Hide resolved
Josh-Larson
reviewed
Jul 8, 2022
src/main/java/com/projectswg/holocore/services/gameplay/player/group/GroupService.kt
Outdated
Show resolved
Hide resolved
Josh-Larson
reviewed
Jul 8, 2022
src/main/java/com/projectswg/holocore/services/gameplay/player/group/GroupService.kt
Outdated
Show resolved
Hide resolved
Josh-Larson
reviewed
Jul 8, 2022
src/main/java/com/projectswg/holocore/services/gameplay/player/group/GroupService.kt
Outdated
Show resolved
Hide resolved
Josh-Larson
reviewed
Jul 15, 2022
| val creo = player.creatureObject | ||
| creo ?: return | ||
| val group = getGroup(creo.groupId) | ||
| group ?: return |
There was a problem hiding this comment.
This the the 2 above it can be replaced with
val group = getGroup(creo.groupId) ?: return
Josh-Larson
reviewed
Jul 15, 2022
| } | ||
|
|
||
| private fun handleMakeLeader(currentLeader: Player, newLeader: CreatureObject?) { | ||
| newLeader ?: return |
There was a problem hiding this comment.
If this is the case should probably just change the function to be not-null
There was a problem hiding this comment.
And then up in the when, can add a ?: return
Josh-Larson
reviewed
Jul 15, 2022
| updateChatRoom(player, group, UpdateType.JOIN) | ||
| } | ||
|
|
||
| private fun removePlayerFromGroup(creature: CreatureObject?) { |
There was a problem hiding this comment.
Should probably be a non-null parameter
…nefit from null-checking by the compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #619
I've tried splitting this into multiple commits, so it's a bit easier to see what's refactoring and what's fixing the actual bug.
The last commit, 630b80a, contains the actual bug fix.