Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed species restrictions from weapons, as no weapon is actually i… #636

Conversation

madsboddum
Copy link
Member

…n serverdata/appearance/appearance_table.sdb causing them to be unequippable

Also added some regression tests

This bug was introduced in #635.

@madsboddum madsboddum marked this pull request as draft July 8, 2022 22:59
@madsboddum madsboddum force-pushed the weapon_species_restrictions branch from 75ba7ee to 54fbb2f Compare July 8, 2022 23:00
@madsboddum madsboddum marked this pull request as ready for review July 8, 2022 23:01
@madsboddum madsboddum requested a review from Josh-Larson July 8, 2022 23:01
@madsboddum madsboddum self-assigned this Jul 8, 2022
@madsboddum madsboddum added the BUGFIX Fix of a bug (Pull Request) label Jul 8, 2022
@madsboddum
Copy link
Member Author

madsboddum commented Jul 8, 2022

Test works fine locally

@madsboddum madsboddum force-pushed the weapon_species_restrictions branch from 8c3acdf to 5be1a8d Compare July 8, 2022 23:35
…n serverdata/appearance/appearance_table.sdb causing them to be unequippable

Also added some regression tests

Removed species restrictions from weapons, as no weapon is actually in serverdata/appearance/appearance_table.sdb causing them to be unequippable

Also added some regression tests
@madsboddum madsboddum force-pushed the weapon_species_restrictions branch from 5be1a8d to fd96500 Compare July 9, 2022 13:08
@madsboddum
Copy link
Member Author

Just noticed I had two commits that were actually supposed to just be one, so I merged them together.

@Undercova Undercova added this to the Game Update 2 - Brawler milestone Jul 9, 2022
@Josh-Larson Josh-Larson merged commit e03bd08 into ProjectSWGCore:cu_quality_assurance Jul 10, 2022
@madsboddum madsboddum deleted the weapon_species_restrictions branch July 10, 2022 22:21
@Undercova
Copy link
Member

Working as intended

@Undercova Undercova linked an issue Jul 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUGFIX Fix of a bug (Pull Request)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trandoshans shouldn't be able to wear boots and gloves
3 participants