Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added TF coil shape optimization #10

Merged
merged 33 commits into from
Dec 30, 2021
Merged

added TF coil shape optimization #10

merged 33 commits into from
Dec 30, 2021

Conversation

TimSlendebroek
Copy link
Contributor

No description provided.

orso82
orso82 reviewed Nov 17, 2021
View reviewed changes
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated
if layer.shape == 1
xTF, yTF = princeton_D(layer.end_radius, IMAS.get_radial_build(rb, identifier=layer.identifier, hfs=1).start_radius, closed=true)
elseif layer.shape == 2
xTF, yTF = rectangle_shape(layer.end_radius,IMAS.get_radial_build(rb, identifier=layer.identifier, hfs=1).start_radius,layer.shape_parameters[1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think more and carefully about how we decide the parameters of the coils shape (eg. the height of the rectangle). For example, in the case of the rectangle, it would be nicer to express the z as the clearance of the TF from the layer inside (e.g. the blanket)...

src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
orso82
orso82 requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@orso82 orso82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I have not tested it yet, but left you some comments to address. I'll give it a try once your are done :)

src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/actors/radial_build_actor.jl Outdated Show resolved Hide resolved
src/physics.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
@orso82
Copy link
Member

orso82 commented Dec 18, 2021

Ouch. rb --> build may have been ok, but as a separate PR (certainly as a separate commit!). This confounds the changes that you have made, and you'll have now a lot of conflicts as other changes are pushed to master before this PR is merged.

@TimSlendebroek
Copy link
Contributor Author

That makes sense :(
Unless we merge it soon!
I saw I messed up one verbose -> vebuildose in the radial build example

@orso82
Copy link
Member

orso82 commented Dec 18, 2021

hehe, yes, and you also touched my jupyter notebook ;) though I understand why you did.
Let's leave rb-->built for a separate PR.

@orso82 orso82 changed the title added TF coil shape (WIP) added TF coil shape optimization Dec 30, 2021
@orso82 orso82 merged commit ee33693 into master Dec 30, 2021
@orso82 orso82 deleted the TF_coil_shape branch December 30, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orso82 orso82 orso82 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimSlendebroek @orso82