Creation of ActorPowerNeeds initial commit #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orso82 although not perfect yet I think this should be pushed |
orso82
reviewed
Mar 15, 2023
| @@ -54,6 +49,12 @@ function ActorHeatTransfer(dd::IMAS.dd, act::ParametersAllActors; kw...) | |||
| return actor | |||
| end | |||
|
|
|||
| function ActorHeatTransfer(dd::IMAS.dd, par::FUSEparameters__ActorHeatTransfer, act::ParametersAllActors; kw...) | |||
There was a problem hiding this comment.
Looks like you're missing the act field in the ActorHeatTransfer structure, though that does not appear to be used, so why have it?
| function ActorThermalCycle(dd::IMAS.dd, par::FUSEparameters__ActorThermalCycle, act::ParametersAllActors; kw...) | ||
| logging_actor_init(ActorThermalCycle) | ||
| par = par(kw...) | ||
| return ActorThermalCycle(dd, par, act.ActorHeatTransfer) |
There was a problem hiding this comment.
This works, but we have generally keep the whole act. Maybe stick with it to be consistent with how compound actors are handled elsewhere?
Suggested change
| return ActorThermalCycle(dd, par, act.ActorHeatTransfer) | |
| return ActorThermalCycle(dd, par, act) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.