Integrate NEO with ActorNeoclassical #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orso82
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Nice job @adrianaghiozzi !!
I have some comments that I think will make the code cleaner and clearer to read.
Once you fix these things, I think we should merge your changes so that @TimSlendebroek can test them.
One more thing, can you also update the FUSE/Makefile to make it pull in the NEO.jl package? It should be quite self-explanatory how to do it. Simply copy the pattern of the other FUSE dependencies.
| @@ -64,17 +105,26 @@ end | |||
| Writes ActorNeoclassical results to dd.core_transport | |||
| """ | |||
| function _finalize(actor::ActorNeoclassical) | |||
| par = actor.par | |||
There was a problem hiding this comment.
This is good, you can then simplify all actor.par below to be simply par
Co-authored-by: Orso Meneghini <[email protected]>
…ormat out of ActorNeoclassical This conversion is now done within the NEO.run_neo function and the outputs are returned in the form of the IMAS.flux_solution object
|
Some comparison between full neo and chang-hinton on a DIII-D case where neoclassical fluxes are significant 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses NEO.jl to run NEO from FUSE and parses output files to return NEO electron particle and energy flux plus total ion flux