Fixing transport equilibrium workflow #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orso82
requested changes
Apr 3, 2022
| @@ -85,21 +93,27 @@ function transport_validation_workflow(; | |||
| par = Parameters(run_df[idx, :]) | |||
| simple_equilibrium_transport_workflow(dd, par; save_directory, do_plot=show_dd_plots, warn_nn_train_bounds=false) | |||
| tau_FUSE[idx] = @ddtime(dd.summary.global_quantities.tau_energy.value) | |||
| catch | |||
| if verbose | |||
| display(println("τ_fuse = $(@ddtime(dd.summary.global_quantities.tau_energy.value)) τ_hdb5 = $(run_df[idx, :TAUTH])")) | |||
There was a problem hiding this comment.
Suggested change
| display(println("τ_fuse = $(@ddtime(dd.summary.global_quantities.tau_energy.value)) τ_hdb5 = $(run_df[idx, :TAUTH])")) | |
| display(println("τ_fuse = $(tau_FUSE[idx]) τ_hdb5 = $(run_df[idx, :TAUTH])")) |
orso82
reviewed
Apr 6, 2022
Allowing for upper/lower and double null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a massive bug I introduced myself in handling ohmic heating, fixed it in this PR.
related to issue #46