Fix savedir, request mem and mem usage #803
Conversation
TimSlendebroek
force-pushed
the
Windows_get_mem_fix
branch
from
e3e0c6f to
decfcf5
Compare
src/utils_begin.jl
Outdated
| @@ -324,19 +324,20 @@ Determines what the maximum memory is based on the device type (apple, windows, | |||
| function localhost_memory() | |||
| if Sys.isapple() | |||
| cmd = `sysctl hw.memsize` # for OSX | |||
| mem_size = parse(Int, match(r"\d+", readchomp(cmd)).match) / 1024^3 | |||
| mem_size = parse(Int, match(r"\d+", readchomp(cmd)).match) / 1024^3 # GiB | |||
| elseif Sys.isunix() | |||
There was a problem hiding this comment.
I am a bit worried about this Sys.isunix() test before Sys.islinux() test
There was a problem hiding this comment.
Nothing was changed with respect to that (just a comment that this in GiB)
There was a problem hiding this comment.
ok, but should we move the Sys.isunix() check as the last option?
I fear that a Linux system might fall into this if statement and not go in the Sys.islinux()
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 59.76% 59.71% -0.06%
==========================================
Files 105 105
Lines 10501 10510 +9
==========================================
Hits 6276 6276
- Misses 4225 4234 +9 ☔ View full report in Codecov by Sentry. |
Do we want the windows test back? I'd be in favor as I will probably run it from windows now Can we add an exception to the code coverage when it comes to certain parts? |
No description provided.