Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PCHIPInterpolation dependency #48

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Remove PCHIPInterpolation dependency #48

merged 2 commits into from
Dec 21, 2024

Conversation

bclyons12
Copy link
Member

Use PCHIP interpolation available natively through DataInterpolations

@bclyons12 bclyons12 requested a review from orso82 December 21, 2024 17:57
@bclyons12 bclyons12 self-assigned this Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.50%. Comparing base (a1519dc) to head (d6a551a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/math.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   38.50%   38.50%           
=======================================
  Files          13       13           
  Lines       28439    28437    -2     
=======================================
  Hits        10950    10950           
+ Misses      17489    17487    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bclyons12 bclyons12 merged commit f75febf into master Dec 21, 2024
6 checks passed
@bclyons12 bclyons12 deleted the update_pchip branch December 21, 2024 18:14
@orso82
Copy link
Member

orso82 commented Dec 22, 2024

Thank you @bclyons12 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants